Alternate sync implementation for non-update blocks - Closes #11099

core/src/mindustry/core/NetServer.java

@@ -23,6 +23,7 @@ import mindustry.net.*;
 import mindustry.net.Administration.*;
 import mindustry.net.Packets.*;
 import mindustry.world.*;
+import mindustry.world.meta.*;
 
 import java.io.*;
 import java.net.*;
@@ -931,19 +932,20 @@ public class NetServer implements ApplicationListener{
         syncStream.reset();
 
         short sent = 0;
-        for(Building entity : Groups.build){
+        for(var team : state.teams.present){
-            if(!entity.block.sync) continue;
+            for(var build : indexer.getFlagged(team.team, BlockFlag.synced)){
-            sent++;
+                sent++;
 
-            dataStream.writeInt(entity.pos());
+                dataStream.writeInt(build.pos());
-            dataStream.writeShort(entity.block.id);
+                dataStream.writeShort(build.block.id);
-            entity.writeSync(Writes.get(dataStream));
+                build.writeSync(Writes.get(dataStream));
 
-            if(syncStream.size() > maxSnapshotSize){
+                if(syncStream.size() > maxSnapshotSize){
-                dataStream.close();
+                    dataStream.close();
-                Call.blockSnapshot(sent, syncStream.toByteArray());
+                    Call.blockSnapshot(sent, syncStream.toByteArray());
-                sent = 0;
+                    sent = 0;
-                syncStream.reset();
+                    syncStream.reset();
+                }
             }
         }
 

core/src/mindustry/world/Block.java

@@ -1240,6 +1240,10 @@ public class Block extends UnlockableContent implements Senseable{
             flags = flags.with(BlockFlag.hasFogRadius);
         }
 
+        if(sync){
+            flags = flags.with(BlockFlag.synced);
+        }
+
         //initialize default health based on size
         if(health == -1){
             boolean round = false;

core/src/mindustry/world/blocks/storage/CoreBlock.java

@@ -71,6 +71,7 @@ public class CoreBlock extends StorageBlock{
         priority = TargetPriority.core;
         flags = EnumSet.of(BlockFlag.core);
         unitCapModifier = 10;
+        sync = false; //core items are synced elsewhere
         drawDisabled = false;
         canOverdrive = false;
         commandable = true;

core/src/mindustry/world/blocks/storage/StorageBlock.java

@@ -21,6 +21,7 @@ public class StorageBlock extends Block{
         hasItems = true;
         solid = true;
         update = false;
+        sync = true;
         destructible = true;
         separateItemCapacity = true;
         group = BlockGroup.transportation;

core/src/mindustry/world/meta/BlockFlag.java

@@ -31,7 +31,8 @@ public enum BlockFlag{
     unitAssembler,
     hasFogRadius,
     steamVent,
-    blockRepair;
+    blockRepair,
+    synced;
 
     public final static BlockFlag[] all = values();