Astronand/Mindustry
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix the sfx selection gui for playsound (#10095)

Browse Source 
* fix the index used to get the sfx substring

* handle cases where the sxf variable is not a built-in

This prevents a crash that happened whenever the sfx
variable's name had less than 5 characters (4 before this
pr), since the substring method was called regardless of
the name's size.
This commit is contained in:
JeanJPNM
2024-08-06 21:27:25 -03:00
committed by GitHub
parent b4a1232407
commit 2ad38fc3b0
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
core/src/mindustry/logic/LStatements.java
View File

@@ -2149,7 +2149,8 @@ public class LStatements{
table.button(b -> { table.button(b -> {
b.image(Icon.pencilSmall); b.image(Icon.pencilSmall);
b.clicked(() -> showSelect(b, GlobalVars.soundNames.toArray(String.class), id.substring(4), t -> { String soundName = id.startsWith("@sfx-") ? id.substring(5) : id;
b.clicked(() -> showSelect(b, GlobalVars.soundNames.toArray(String.class), soundName, t -> {
id = "@sfx-" + t; id = "@sfx-" + t;
rebuild(table); rebuild(table);
}, 2, cell -> cell.size(160, 50))); }, 2, cell -> cell.size(160, 50)));