From b66eb173d88e8ac056fdf4e283dd81d8d6cd8b98 Mon Sep 17 00:00:00 2001 From: buthed010203 Date: Fri, 15 Oct 2021 16:07:15 -0400 Subject: [PATCH 1/2] Consistency (#6163) * Consistency Why is this inconsistent with the portion just above it? * C o n s i s t e n t --- core/src/mindustry/ai/types/BuilderAI.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/core/src/mindustry/ai/types/BuilderAI.java b/core/src/mindustry/ai/types/BuilderAI.java index 6d6a0fa5c9..b083216573 100644 --- a/core/src/mindustry/ai/types/BuilderAI.java +++ b/core/src/mindustry/ai/types/BuilderAI.java @@ -68,7 +68,7 @@ public class BuilderAI extends AIController{ //approach request if building BuildPlan req = unit.buildPlan(); - //clear break plan if another player is breaking something. + //clear break plan if another player is breaking something if(!req.breaking && timer.get(timerTarget2, 40f)){ for(Player player : Groups.player){ if(player.isBuilder() && player.unit().activelyBuilding() && player.unit().buildPlan().samePos(req) && player.unit().buildPlan().breaking){ @@ -131,16 +131,15 @@ public class BuilderAI extends AIController{ //check if it's already been placed if(world.tile(block.x, block.y) != null && world.tile(block.x, block.y).block().id == block.block){ blocks.removeFirst(); - }else if(Build.validPlace(content.block(block.block), unit.team(), block.x, block.y, block.rotation)){ //it's valid. + }else if(Build.validPlace(content.block(block.block), unit.team(), block.x, block.y, block.rotation)){ //it's valid lastPlan = block; - //add build request. + //add build request unit.addBuild(new BuildPlan(block.x, block.y, block.rotation, content.block(block.block), block.config)); - //shift build plan to tail so next unit builds something else. + //shift build plan to tail so next unit builds something else blocks.addLast(blocks.removeFirst()); }else{ //shift head of queue to tail, try something else next time - blocks.removeFirst(); - blocks.addLast(block); + blocks.addLast(blocks.removeFirst()); } } } From f683496440d735536db40878f142a5782dfc64c2 Mon Sep 17 00:00:00 2001 From: Anuken Date: Fri, 15 Oct 2021 14:24:40 -0400 Subject: [PATCH 2/2] cleanup --- core/src/mindustry/content/Blocks.java | 5 +---- core/src/mindustry/entities/comp/PlayerComp.java | 2 +- core/src/mindustry/world/blocks/environment/EmptyFloor.java | 3 +++ 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/core/src/mindustry/content/Blocks.java b/core/src/mindustry/content/Blocks.java index b9204490a9..74bd9d6e40 100644 --- a/core/src/mindustry/content/Blocks.java +++ b/core/src/mindustry/content/Blocks.java @@ -237,10 +237,7 @@ public class Blocks implements ContentList{ canShadow = false; }}; - empty = new EmptyFloor("empty"){{ - placeableOn = false; - solid = true; - }}; + empty = new EmptyFloor("empty"); stone = new Floor("stone"); diff --git a/core/src/mindustry/entities/comp/PlayerComp.java b/core/src/mindustry/entities/comp/PlayerComp.java index 791157ad56..38a43cae87 100644 --- a/core/src/mindustry/entities/comp/PlayerComp.java +++ b/core/src/mindustry/entities/comp/PlayerComp.java @@ -38,11 +38,11 @@ abstract class PlayerComp implements UnitController, Entityc, Syncc, Timerc, Dra boolean admin; String name = "frog"; Color color = new Color(); - //locale should not be synced. transient String locale = "en"; transient float deathTimer; transient String lastText = ""; transient float textFadeTime; + transient private Unit lastReadUnit = Nulls.unit; transient private int wrongReadUnits; transient @Nullable Unit justSwitchFrom, justSwitchTo; diff --git a/core/src/mindustry/world/blocks/environment/EmptyFloor.java b/core/src/mindustry/world/blocks/environment/EmptyFloor.java index 3b1aba9e82..436150792d 100644 --- a/core/src/mindustry/world/blocks/environment/EmptyFloor.java +++ b/core/src/mindustry/world/blocks/environment/EmptyFloor.java @@ -3,12 +3,15 @@ package mindustry.world.blocks.environment; import mindustry.content.*; import mindustry.world.*; +/** Empty floor is *not* equivalent to air. Unlike air, it is solid, and still draws neighboring tile edges. */ public class EmptyFloor extends Floor{ public EmptyFloor(String name){ super(name); variants = 0; canShadow = false; + placeableOn = false; + solid = true; } @Override